Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/time types #64

Merged
merged 4 commits into from
May 31, 2022
Merged

Feature/time types #64

merged 4 commits into from
May 31, 2022

Conversation

JurajSadel
Copy link
Contributor

Closes #24

@MabezDev
Copy link
Member

To fix the compile errors, although we don't want to touch the utils too much, we'll need to add a conversion from TICKS to NanoSecondsu32. I think you can use https://docs.rs/fugit/0.3.5/fugit/struct.Duration.html#method.from_ticks to do that.

MabezDev
MabezDev approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good from my end, just a small nit about the examples, nothing to worry about though.

esp32-hal/examples/i2c_display.rs Outdated Show resolved Hide resolved
@JurajSadel JurajSadel marked this pull request as ready for review May 30, 2022 11:57
@MabezDev MabezDev merged commit b382a01 into esp-rs:main May 31, 2022
@JurajSadel JurajSadel deleted the feature/time_types branch February 28, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessebraham jessebraham jessebraham left review comments

@MabezDev MabezDev MabezDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Time types
3 participants
@JurajSadel @MabezDev @jessebraham