Remove unnecessary rt crate dependencies
#391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernQ
force-pushed
the
remove-unnecessary-rt-crate-deps
branch
from
637a1b7
to
5b562da
Compare
|
New PACs are published. |
MabezDev
approved these changes
Feb 10, 2023
| @@ -35,20 +33,3 @@ fn main() -> ! { | |||
|
|
|||
| loop {} | |||
| } | |||
|
|
|||
| #[xtensa_lx_rt::exception] | |||
There was a problem hiding this comment.
Oh wow, this is prehistoric 😃 - good to get rid of this!
jessebraham
approved these changes
Feb 10, 2023
There was a problem hiding this comment.
Lots to take in here but I think things are looking pretty good, sorry for the delay in reviewing this (turns out I had started and forgot to finish 😅).
I have a few nitpicks but honestly they're so minor I won't even bring them up, they can be dealt with some other time, so LGTM. Thanks for all this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #382
rtcrates andriscv/xtensa-lxfrom the chip specific HALs, re-export from esp-hal-commonriscv/xtensa-lxin the chip specific HALsentryis re-exported and added to the preludeThis PR looks huge but most of the changes are in the examples.
Nice side-effect: fixes #197
This has some potential for bikeshedding about some names (e.g.
trapframe::TrapFrame) - I tried to choose the names carefully but don't have strong opinions about themBEFORE merging this
xtensa-lx-rtversion, probably alsoxtensa-lxrtdependencies)esp-backtraceThis also bumps the versions of all contained crates