Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GPIO interrupts for pins > 31 #335

Merged
merged 2 commits into from
Jan 6, 2023
Merged

Fix GPIO interrupts for pins > 31 #335

merged 2 commits into from
Jan 6, 2023

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Jan 6, 2023

Fixes #332

Took me a bit too long because I fell into a "generics" rabbit-hole

@bjoernQ bjoernQ requested a review from MabezDev January 6, 2023 09:45
MabezDev
MabezDev requested changes Jan 6, 2023
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a bit too long because I fell into a "generics" rabbit-hole

We've all been there :D.

esp-hal-common/src/gpio.rs Outdated Show resolved Hide resolved
MabezDev
MabezDev approved these changes Jan 6, 2023
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. LGTM!

@bjoernQ bjoernQ merged commit a0b976d into esp-rs:main Jan 6, 2023
@bjoernQ bjoernQ deleted the bugfix/fix-gpio-interrupts-pins-gt-31 branch January 6, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MabezDev MabezDev MabezDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GPIO incorrect interrupt status for pins > 32
2 participants
@bjoernQ @MabezDev