Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API guideline touchups #2573

Merged
merged 2 commits into from
Nov 21, 2024
Merged

API guideline touchups #2573

merged 2 commits into from
Nov 21, 2024

Conversation

MabezDev
Copy link
Member

No description provided.

@MabezDev MabezDev added the skip-changelog No changelog modification needed label Nov 20, 2024
@MabezDev MabezDev mentioned this pull request Nov 20, 2024
Open
bjoernQ
bjoernQ approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might still want to decide on the single-peripheral instance case, but the changes here look fine to me. Thanks

@jessebraham jessebraham added this pull request to the merge queue Nov 21, 2024
Merged via the queue into esp-rs:main with commit 2fc10d6 Nov 21, 2024
28 checks passed
@MabezDev MabezDev deleted the guidelines-update branch November 21, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bugadani bugadani bugadani left review comments

@bjoernQ bjoernQ bjoernQ approved these changes

@jessebraham jessebraham jessebraham approved these changes

Assignees
No one assigned
Labels
skip-changelog No changelog modification needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MabezDev @bugadani @jessebraham @bjoernQ