esp-println: avoid double locking when using auto #2567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
force-pushed
the
println-lock
branch
from
57db824
to
2e70468
Compare
bugadani
commented
Nov 19, 2024
| @@ -145,27 +145,19 @@ mod auto_printer { | |||
| unsafe { (USB_DEVICE_INT_RAW.read_volatile() & SOF_INT_MASK) != 0 } | |||
| } | |||
|
|
|||
| pub fn write_bytes_assume_cs(bytes: &[u8]) { | |||
| pub fn write_bytes_in_cs(bytes: &[u8], token: LockToken<'_>) { | |||
There was a problem hiding this comment.
For the record: LockToken was introduced explicitly to clean up the double-locking here - by making it obvious that we're already in with.
|
Ah damn println doesn't depend on esp-hal :/ |
bugadani
force-pushed
the
println-lock
branch
from
2e70468
to
cd6f573
Compare
bugadani
changed the title
bugadani
force-pushed
the
println-lock
branch
5 times, most recently
from
89c0e1b
to
e2cda55
Compare
bugadani
force-pushed
the
println-lock
branch
from
e2cda55
to
c989022
Compare
It was a deliberate decision to not depend on the HAL in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.