Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom AtomicWaker and embassy-sync mutex implementation #2555

Merged
merged 6 commits into from
Nov 23, 2024
Merged

Add custom AtomicWaker and embassy-sync mutex implementation #2555

merged 6 commits into from
Nov 23, 2024

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Nov 15, 2024 •
edited
Loading

Closes #2553

@bugadani bugadani added the skip-changelog No changelog modification needed label Nov 15, 2024
@bugadani
Copy link
Contributor Author

skip-changelog because esp-wifi changed but it's only a user

@bugadani bugadani marked this pull request as draft November 15, 2024 22:16
Dominaezzz
Dominaezzz reviewed Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@Dominaezzz Dominaezzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ik it's draft and a Friday, but I was curious

esp-hal/src/lib.rs Outdated Show resolved Hide resolved
@bugadani bugadani removed the skip-changelog No changelog modification needed label Nov 18, 2024
@bugadani bugadani marked this pull request as ready for review November 18, 2024 08:00
@bugadani bugadani added the skip-changelog No changelog modification needed label Nov 18, 2024
Dominaezzz
Dominaezzz reviewed Nov 18, 2024
View reviewed changes
esp-hal/src/lib.rs Outdated Show resolved Hide resolved
bjoernQ
bjoernQ approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - not sure this should go into the upcoming release or not

@bugadani bugadani marked this pull request as draft November 20, 2024 10:57
@bugadani bugadani marked this pull request as ready for review November 21, 2024 07:47
MabezDev
MabezDev requested changes Nov 21, 2024
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise LGTM, just need to find a better place to put it :D

esp-hal/src/lib.rs Outdated Show resolved Hide resolved
esp-hal/src/lib.rs Outdated Show resolved Hide resolved
@bugadani bugadani marked this pull request as draft November 22, 2024 07:52
@bugadani bugadani added status:blocked Unable to progress - dependent on another task skip-changelog No changelog modification needed and removed skip-changelog No changelog modification needed labels Nov 22, 2024
@bugadani bugadani removed the status:blocked Unable to progress - dependent on another task label Nov 22, 2024
@bugadani bugadani marked this pull request as ready for review November 22, 2024 20:34
@bugadani bugadani changed the title Add custom AtomicWaker Add custom AtomicWaker and embassy-sync mutex implementation Nov 22, 2024
MabezDev
MabezDev approved these changes Nov 23, 2024
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MabezDev MabezDev added this pull request to the merge queue Nov 23, 2024
Merged via the queue into esp-rs:main with commit 45395d4 Nov 23, 2024
28 checks passed
@bugadani bugadani deleted the waker branch November 23, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dominaezzz Dominaezzz Dominaezzz left review comments

@MabezDev MabezDev MabezDev approved these changes

@bjoernQ bjoernQ bjoernQ approved these changes

Assignees
No one assigned
Labels
skip-changelog No changelog modification needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add and use a dual-core optimized AtomicWaker implementation
4 participants
@bugadani @bjoernQ @MabezDev @Dominaezzz