Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DMA 6/8] More helper types & working split #2532

Merged
merged 7 commits into from
Nov 22, 2024
Merged

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Nov 13, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • I have added necessary changes to user code to the Migration Guide.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

Closes #2401
Closes #1767

@bugadani
Copy link
Contributor Author

I'm open to suggestions for the naming. I'm aware that type erasure hurts us a bit on 32 and S2. I am planning to use different erased types on the P4 so we won't have runtime checks there.

@bugadani bugadani force-pushed the dma-user branch 3 times, most recently from d43a92f to 5eda9a5 Compare November 13, 2024 20:20
@bugadani bugadani force-pushed the dma-user branch 2 times, most recently from e1563e2 to 1f0ad24 Compare November 14, 2024 15:24
@bugadani bugadani changed the title [DMA 6/N] More helper types [DMA 6/8] More helper types Nov 15, 2024
@bugadani bugadani changed the title [DMA 6/8] More helper types [DMA 6/8] More helper types & working split Nov 22, 2024
@Dominaezzz
Copy link
Collaborator

This also closes #1767

@bugadani bugadani marked this pull request as ready for review November 22, 2024 13:37
@bugadani
Copy link
Contributor Author

I'm a bit unsure whether this amount of documentation is too little, enough or too much, but I guess it's time to collect feedback.

Copy link
Collaborator

@Dominaezzz Dominaezzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't read the doc yet, just one comment

hil-test/tests/lcd_cam.rs Show resolved Hide resolved
esp-hal/src/dma/mod.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@Dominaezzz Dominaezzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'll leave it you to decide when to add split() to the migration guide.

@bugadani
Copy link
Contributor Author

I'll leave it you to decide when to add split() to the migration guide.

Thanks, forgot to add it

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MabezDev MabezDev added this pull request to the merge queue Nov 22, 2024
Merged via the queue into esp-rs:main with commit e98674e Nov 22, 2024
28 checks passed
@bugadani bugadani deleted the dma-user branch November 22, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot work with DMA channels in a generic way Improve DMA Channel APIs
3 participants