-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DMA 6/8] More helper types & working split
#2532
Conversation
I'm open to suggestions for the naming. I'm aware that type erasure hurts us a bit on 32 and S2. I am planning to use different erased types on the P4 so we won't have runtime checks there. |
d43a92f
to
5eda9a5
Compare
e1563e2
to
1f0ad24
Compare
split
This also closes #1767 |
I'm a bit unsure whether this amount of documentation is too little, enough or too much, but I guess it's time to collect feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't read the doc yet, just one comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'll leave it you to decide when to add split()
to the migration guide.
Thanks, forgot to add it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packages
command to ensure that all changed code is formatted correctly.CHANGELOG.md
in the proper section.Extra:
Pull Request Details 📖
Description
Closes #2401
Closes #1767