-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIL(QOL): Add missing timeouts to various tests #2489
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! It would be cool to have a default timeout that we could set. Thanks!
I'd prefer investing into probe-rs/embedded-test#3 instead. |
Thanks for pointing that out, was going to suggest opening an issue upstream. |
I guess probe-rs/embedded-test#3 is the best way to go (is no timeout at all ever a good idea ....?) So, what should happen with this PR? Does it solve a real problem we have currently? (Then we might want to get it in until we have a global timeout) |
The default is 30 seconds right now, there is no such thing as no timeout in embedded-test. |
Oh good - I never had the patience to wait 30 secs .... I don't see where the code sets 30 secs if None but I didn't try hard to find it |
My bad it's 60 |
Ah thanks .... the runner does it on its own .... no wonder I wasn't able to find it in embedded-test itself 😆 |
PR pending: probe-rs/embedded-test#44 |
Thank you! I will mark this as a draft and when it gets merged, I can update our HIL. |
You can use Daniel's branch with |
No description provided.