Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add high level CPU interrupts for ESP32-S3 direct-boot #238

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Oct 31, 2022

This fixes #236 but doesn't contain any modification of the CI workflow to check the direct-boot feature

@MabezDev
Copy link
Member

Is this because we don't use the xtensa-lx-rt linker script in direct boot mode? I ask because we already have the definitions in there: https://github.com/esp-rs/xtensa-lx-rt/blob/654c9302a4f2c615cc5e19a226a39b597f25eadd/exception-esp32.x.jinja#L16-L23

@bjoernQ
Copy link
Contributor Author

bjoernQ commented Oct 31, 2022

Is this because we don't use the xtensa-lx-rt linker script in direct boot mode? I ask because we already have the definitions in there: https://github.com/esp-rs/xtensa-lx-rt/blob/654c9302a4f2c615cc5e19a226a39b597f25eadd/exception-esp32.x.jinja#L16-L23

Yes, for direct-boot we can't use the xtensa-lx-rt linker script as far as I remember and need to duplicate most of it here

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha! In which case, this looks good to me :)

@bjoernQ bjoernQ merged commit 5aedd3e into esp-rs:main Oct 31, 2022
@bjoernQ bjoernQ deleted the bugfix/fix-esp32s3-direct-boot branch October 31, 2022 11:28
@jessebraham
Copy link
Member

Thanks for fixing this, I can get the CI updated this week most likely to try and avoid this in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

esp32s3-hal can no longer be built with the direct-boot feature enabled
3 participants