-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove most trait implementation features from esp-hal
#2047
Conversation
The changes to |
esp-hal/Cargo.toml
Outdated
embassy-futures = "0.1.1" | ||
embassy-sync = "0.6.0" | ||
embassy-usb-driver = "0.1.0" | ||
embassy-usb-synopsys-otg = "0.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think embassy-usb* should still be gated, behind usb-otg.
I'm glad I have two arguments:
|
My suggestion is to roll with this and deal with the fallout later, if there is any. embassy is usually a pretty good example to follow and they don't have any issues with similarly unconditional implementations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Reminder to not merge before we released #2004 is released |
5eb4f26
to
1caa796
Compare
Welp just nuked this branch by accident, oops. Will fix at some point and either re-open this or open a new PR. |
This began as a quest to eliminate the
async
feature, however we came to the conclusion that none of these features are really necessary, and they just needlessly complicate things. These packages largely contain a couple traits and/or types only, so build times should not be affected significantly.If anybody thinks any of these features should remain I'm willing to hear your arguments, but as I said I really don't think there is any need.
Closes #2007