-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rustls examples #1899
base: main
Are you sure you want to change the base?
Add Rustls examples #1899
Conversation
Fixes #1836 While Rustls will also work on H2 no examples are added for H2 |
TLS is the next major part after getting the HAL and drivers running. Many protocols and systems use/require it, especially in IoT development. Now the question lies down to; What is the roadmap? Should All three of the above mentionned TLS suites support a different set of features, and compatibility. I believe both Rustls and embedded-tls to be the future of TLS on bare-metal, since they are more lightweight and pure Rust implementation. This should be documented for new users who come across needing to use TLS on bare-metal. Rustls
embedded-tls
esp-mbedtls
|
I can build both examples for |
I totally agree that TLS is an important topic We don't have an official TLS roadmap ,yet - but I'd say both, Rustls and embedded-tls (both HW accelerated) is something I personally want. After my vacation I'll look into lifting the atomics requirement for Rustls so it will work on all our targets |
I've converted to draft until we can support all chips, hopefully it won't take too long to get upstream to allow using portable-atomic 🤞 |
Just taking another look at this, maybe we should merge this in it's current state? We know the upstream issue needs to be resolved for the non-atomic targets, but that doesn't mean we can't land support for the atomic's target now, I think? |
Submission Checklist 📝
cargo xtask fmt-packages
command to ensure that all changed code is formatted correctly.CHANGELOG.md
in the proper section.Extra:
Pull Request Details 📖
Description
This adds two examples using Rustls (a client and a server) for ESP32, ESP32-S3 and ESP32-C6.
Something I learnt just now is that currently it's impossible to compile Rustls for targets w/o atomics - I opened an issue in the Rustls repo for that. (i.e. it's the usage of
alloc::sync::Arc
in Rustls itself - seems like all the dependencies can be tweaked to useportable-atomic
)Given that, I'm not sure if these examples are something we currently want to have in the repo? I am also happy to extract the examples and the supporting code into its own repo in my personal GitHub space fow now otherwise
Testing
Running the examples on supported targets