-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix feeding of RWDT
#1645
Fix feeding of RWDT
#1645
Conversation
Ahh classic forgot to check the other chips 😁 |
@@ -788,7 +788,10 @@ impl Rwdt { | |||
let rtc_cntl = unsafe { &*LP_WDT::PTR }; | |||
|
|||
self.set_write_protection(false); | |||
rtc_cntl.wdtfeed().write(|w| unsafe { w.bits(1) }); | |||
#[cfg(any(esp32c6, esp32h2))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sucks, but I already published new PACs for the upcoming release. I will update the PACs in the repo, then make a note to fix this after we've published.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The feed bit is the highest bit, so I guess that the previous implementation was setting the lowest bit instead.
Closes #1534