include bss size when calculating rwtext address #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Switched to draft based on #144 (comment) will look into this again in the morning. |
If bss contained anything a linker error was emitted about overlapping sections. Moving the .bss section to after the .rwtext, and adding a dummy section to pad data bus access to the bss section fixes this.
MabezDev
force-pushed
the
bugfix/db-bss-section
branch
from
e2e8d42
to
99ae152
Compare
|
Thanks for the pointer @gustavonihei, I've switched to the method used in the MCU boot PR. |
gustavonihei
approved these changes
Aug 9, 2022
|
Looks good and I can flash and run it 👍 |
|
Thanks all ... my own project also works again after this fix :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #144