Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime ISR binding and simple public API docs for RTC #1405

Merged
merged 3 commits into from
Apr 5, 2024

Conversation

JurajSadel
Copy link
Contributor

@JurajSadel JurajSadel commented Apr 5, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • My changes were added to the CHANGELOG.md in the proper section.

Extra:

Pull Request Details 📖

Description

Use runtime ISR binding for RTC and adds docs for public API.

Testing

Run modified clock_monitor and rtc_watchdog examples.

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - also added some more docs 👍

esp-hal/src/rtc_cntl/mod.rs Outdated Show resolved Hide resolved
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jessebraham jessebraham added this pull request to the merge queue Apr 5, 2024
Merged via the queue into esp-rs:main with commit 1e6165e Apr 5, 2024
21 checks passed
@JurajSadel JurajSadel deleted the rtc-wdt-isr-binding branch April 10, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants