-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract inner modules of gpio
module into their own files
#1397
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I'm pretty new with the peripheral, changes LGTM and the renaming also makes sense to me. Just left 2 minors docstrings suggestions that you can ignore if you want.
Good eye @SergioGasquez, thanks! Doc comment has been added. I just realized there are a number of public items in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I guess the amount of code in each module justifies having them separate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Our GPIO driver is getting quite large and complex, and each of these modules have sufficient complexity to warrant their own files, IMO, so I have extracted the modules.
There is one breaking change here, in that I changed the
lp_gpio
module tolp_io
. This was done for two reasons: to be consistent with the peripheral name (LP_IO
) and to be consistent with thertc_io
module in the same driver. I can revert this change if needed.