Fix up docs and features; default to enabling eh1 instead of eh02 #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MabezDev
commented
Mar 20, 2024
MabezDev
force-pushed
the
document-more-features
branch
2 times, most recently
from
a5ebfd9 to
747a9b2
Compare
jessebraham
reviewed
Mar 20, 2024
|
I think to resolve the remaining CI failures, we just need to add |
MabezDev
force-pushed
the
document-more-features
branch
from
121dca7 to
e47a73b
Compare
MabezDev
force-pushed
the
document-more-features
branch
from
e47a73b to
02ff79a
Compare
yanshay
pushed a commit
to yanshay/esp-hal
that referenced
this pull request
Mar 20, 2024
…p-rs#1313) * Fix up docs and features; default to enabling eh1 instead of eh02 * Changelog * Fix twai example * Fixup from defaulting to eh1
yanshay
pushed a commit
to yanshay/esp-hal
that referenced
this pull request
Mar 25, 2024
…p-rs#1313) * Fix up docs and features; default to enabling eh1 instead of eh02 * Changelog * Fix twai example * Fixup from defaulting to eh1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
This PR defaults the enabled eh impl to be eh1 instead of eh02. It also improves some of the docs, by enabling more things when building the docs.
Testing