Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delay::delay #1298

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Delay::delay #1298

merged 2 commits into from
Mar 20, 2024

Conversation

burrbull
Copy link
Contributor

@burrbull burrbull commented Mar 15, 2024 •
edited
Loading

Adds delay(MicrosDurationU64) for Delay.
Removes RateExtU64 as never used and ExtU32 as used only for Rtc.

Removes u32 suffixes on rate and delay_millis as now always takes u32.

@burrbull burrbull marked this pull request as ready for review March 15, 2024 11:06
jessebraham
jessebraham approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jessebraham jessebraham enabled auto-merge March 20, 2024 23:41
@jessebraham jessebraham added this pull request to the merge queue Mar 20, 2024
Merged via the queue into esp-rs:main with commit 4a0a19e Mar 20, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessebraham jessebraham jessebraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burrbull @jessebraham