Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving our own RISCV RT overrides to its own crate #311

Closed
bjoernQ opened this issue Dec 14, 2022 · 4 comments
Closed

Consider moving our own RISCV RT overrides to its own crate #311

bjoernQ opened this issue Dec 14, 2022 · 4 comments
Assignees

Comments

@bjoernQ
Copy link
Contributor

bjoernQ commented Dec 14, 2022

Currently the HALs targeting RISCV (ESP32-C2 and ESP32-C3 currently) include some replacements for the assembly found in riscv-rt

That's redundant code in both HALs - in future we will see more RISCV based chips so it makes sense to move that common functionality into its own crate

While on it we should consider if we want to remove the dependency to riscv-rt completely since there is very little, we use from that

Note: While initially we did that because the mentioned targets don't support mie and ``mip` CSRs we now also need special versions of the trap handler - that means we will continue to need it

@bjoernQ
Copy link
Contributor Author

bjoernQ commented Jan 23, 2023

Also, we could re-export riscv from there and probably can solve situations like the recent yanking of a bunch of riscv versions by releasing a minor update to our crate

@jessebraham
Copy link
Member

I started working on this awhile back actually, I'll dust off the project and try to get it in a repo this week some time.

@jessebraham jessebraham self-assigned this Jan 23, 2023
@jessebraham
Copy link
Member

The package has yet to be published, but a repository has been created:
https://github.com/esp-rs/esp-riscv-rt

Once we've tested it a bit more I will get a release out and update the necessary dependencies to use this package instead.

@jessebraham jessebraham moved this from Todo to In Progress in esp-rs Jan 25, 2023
@jessebraham
Copy link
Member

Closed by #365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants