Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest published HALs and Xtensa toolchain #112

Merged
merged 2 commits into from
Jan 30, 2023
Merged

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Jan 27, 2023

With Xtensa toolchain 1.67 I again experienced funny things regarding opt-levels

@MabezDev
Copy link
Member

FYI opt-level = 3 worked for me on the s2... So maybe @jessebraham you could test too?

@bjoernQ
Copy link
Contributor Author

bjoernQ commented Jan 27, 2023

Double checked it - opt-level 3 works for the DHCP example but not for the static-ip example for me

@ImUrX
Copy link
Contributor

ImUrX commented Jan 29, 2023

should this be using esp-riscv-rt?

Is there also any reason why it even exists? I tried understanding esp-rs/esp-hal#311 but like why is its own crate?

@bjoernQ
Copy link
Contributor Author

bjoernQ commented Jan 29, 2023

The reason esp-riscv-rt exists are outlined in esp-rs/esp-hal#311

@ImUrX
Copy link
Contributor

ImUrX commented Jan 29, 2023

Ok, then I see that this PR is still using riscv-rt instead of the esp one, is there any reason behind that?

@bjoernQ
Copy link
Contributor Author

bjoernQ commented Jan 29, 2023

That is because the latest published HALs are not yet using esp-riscv-rt - that will be in the next release (already merged into main) - might be a confusing situation currently

@ImUrX
Copy link
Contributor

ImUrX commented Jan 29, 2023

God

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will still look into the s2 issues.

@bjoernQ bjoernQ merged commit 05665bc into main Jan 30, 2023
@bjoernQ bjoernQ deleted the prepare-upcoming-hal branch February 1, 2023 09:23
@MabezDev MabezDev mentioned this pull request Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants