Skip to content

Commit

Permalink
address reviews
Browse files Browse the repository at this point in the history
  • Loading branch information
playfulFence committed Nov 21, 2024
1 parent 9ebb840 commit cc2d29b
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 9 deletions.
2 changes: 1 addition & 1 deletion esp-hal/src/i2s/parallel.rs
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
//! Ok(xfer) => xfer,
//! Err(_) => {
//! panic!("Failed to send buffer");
//! }
//! }
//! };
//! (parallel, tx_buf) = xfer.wait();
//! delay.delay_millis(10);
Expand Down
4 changes: 2 additions & 2 deletions esp-hal/src/ledc/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@
//! .unwrap();
//!
//! channel0.start_duty_fade(0, 100, 2000).expect_err(
//! "Fading from 0% to 100%, at 24kHz and 5-bit resolution, over 2 seconds,
//! should fail", );
//! "Fading from 0% to 100% over 2 seconds, should fail",
//! );
//!
//! loop {
//! // Set up a breathing LED: fade from off to on over a second, then
Expand Down
5 changes: 2 additions & 3 deletions qa-test/src/bin/psram_octal.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
//! This shows how to use PSRAM as heap-memory via esp-alloc
//!
//! You need an ESP32-S3 with at least 2 MB of PSRAM memory.
//!
//! Note: PSRAM example must be built in release mode!

//% CHIPS: esp32s3
//% FEATURES: esp-hal/octal-psram
Expand All @@ -27,9 +29,6 @@ fn init_psram_heap(start: *mut u8, size: usize) {
}
}

#[cfg(is_not_release)]
compile_error!("PSRAM example must be built in release mode!");

#[entry]
fn main() -> ! {
esp_println::logger::init_logger_from_env();
Expand Down
5 changes: 2 additions & 3 deletions qa-test/src/bin/psram_quad.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
//! This shows how to use PSRAM as heap-memory via esp-alloc
//!
//! You need an ESP32, ESP32-S2 or ESP32-S3 with at least 2 MB of PSRAM memory.
//!
//! Note: PSRAM example must be built in release mode!

//% CHIPS: esp32 esp32s2 esp32s3
//% FEATURES: esp-hal/quad-psram
Expand All @@ -27,9 +29,6 @@ fn init_psram_heap(start: *mut u8, size: usize) {
}
}

#[cfg(is_not_release)]
compile_error!("PSRAM example must be built in release mode!");

#[entry]
fn main() -> ! {
esp_println::logger::init_logger_from_env();
Expand Down

0 comments on commit cc2d29b

Please sign in to comment.