Skip to content

Commit

Permalink
Only set the set_suc_eof flag on the last item (#359)
Browse files Browse the repository at this point in the history
It was previously hardcoded to true, which meant a DMA suc eof interrupt would fire for every descriptor that was processed
  • Loading branch information
MabezDev authored Jan 24, 2023
1 parent 832f9ef commit 5f933aa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion esp-hal-common/src/dma/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,7 @@ pub(crate) mod private {

let mut dw0 = &mut descriptors[descr];

dw0.set_suc_eof(true);
dw0.set_suc_eof(last);
dw0.set_owner(Owner::Dma);
dw0.set_size(chunk_size as u16); // align to 32 bits?
dw0.set_length(chunk_size as u16); // actual size of the data!?
Expand Down

0 comments on commit 5f933aa

Please sign in to comment.