Use XtalClock as UART source and adapt interrupt binding #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioGasquez
commented
Apr 18, 2024
| @@ -42,5 +43,5 @@ unsafe fn USB_DEVICE() { | |||
|
|
|||
| reg_block | |||
| .int_clr() | |||
| .write(|w| w.serial_out_recv_pkt_int_clr().set_bit()); | |||
| .write(|w| w.serial_out_recv_pkt().clear_bit_by_one()); | |||
There was a problem hiding this comment.
| @@ -41,5 +46,5 @@ fn UART0() { | |||
| unsafe { RX_QUEUE.push_back(data).unwrap() }; | |||
| } | |||
|
|
|||
| uart.int_clr().write(|w| w.rxfifo_full_int_clr().set_bit()); | |||
| uart.int_clr().write(|w| w.rxfifo_full().clear_bit_by_one()); | |||
There was a problem hiding this comment.
JurajSadel
reviewed
Apr 19, 2024
SergioGasquez
force-pushed
the
feat/uart-source-clk
branch
from
25901b9
to
70376a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XtalClockas UART source when possibleTesting
I've tried flashing a few targets (C6 and H2) with the generated stubs and they were working fine.
I've created https://github.com/SergioGasquez/espflash/tree/feat/test-stubs updating all the stubs
and once esp-rs/espflash#625 is merged, I'll run espflash HIL CI on that branch so we can test all the targets with new stubs.Here is the HIL run with the test stubs: https://github.com/esp-rs/espflash/actions/runs/8749962162