This repository has been archived by the owner on May 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
lib: Pretty-print PanicInfo
#5
Merged
jessebraham
merged 2 commits into
esp-rs:main
from
har7an:feature/pretty-panic-messages
Aug 19, 2022
Merged
lib: Pretty-print PanicInfo
#5
jessebraham
merged 2 commits into
esp-rs:main
from
har7an:feature/pretty-panic-messages
Aug 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of relying solely on the `Debug` trait for printing. Also add some more space to the output, so the Panic is easily recognized between application text and the backtrace.
har7an
force-pushed
the
feature/pretty-panic-messages
branch
from
August 19, 2022 12:29
08e0650
to
31a4788
Compare
@bjoernQ I learned another trick yesterday, apparently
What do you think about it? |
Good idea! |
bjoernQ
approved these changes
Aug 19, 2022
@jessebraham what do you think? |
MabezDev
approved these changes
Aug 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is big improvement :)
jessebraham
approved these changes
Aug 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, this is much more pleasant to look at 😁 Thanks for the contribution!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of relying solely on the
Debug
trait for printing. Also addsome more space to the output, so the Panic is easily recognized between
application text and the backtrace.
Currently, accessing the panic
message
is an unstable feature incore
, see this tracking issue: rust-lang/rust#66745So unless this lands, the current debug print actually contains more useful information than this PR...