Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Add support for the ESP32-C6 #26

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Add support for the ESP32-C6 #26

merged 1 commit into from
Feb 28, 2023

Conversation

jessebraham
Copy link
Member

@jessebraham jessebraham commented Feb 23, 2023 •
edited
Loading

Adds support for the ESP32-C6. Also corrects the is_valid_ram_address function, which I vaguely remember discussing with @bjoernQ some number of months ago 😁

I did verify this on hardware, though did not test it very thoroughly.

Closes #12

@jessebraham jessebraham mentioned this pull request Feb 24, 2023
Merged
4 tasks
@jessebraham
Copy link
Member Author

@bjoernQ @MabezDev would one of you mind double-checking these changes, please?

MabezDev
MabezDev approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I also opened #27 because I realized we need to expand the is_valid_ram_address function

bjoernQ
bjoernQ approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessebraham jessebraham merged commit 34a8d31 into esp-rs:main Feb 28, 2023
@jessebraham jessebraham deleted the feature/chip-support branch February 28, 2023 16:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MabezDev MabezDev MabezDev approved these changes

@bjoernQ bjoernQ bjoernQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for the ESP32-C6
3 participants
@jessebraham @bjoernQ @MabezDev