Update Qemu page #146
Merged
Update Qemu page #146
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ahh, may be related with #40 |
src/tooling/simulating/qemu.md
Outdated
| @@ -15,18 +15,20 @@ Once you have built QEMU, you should have the `qemu-system-xtensa` file. | |||
| For running our project in QEMU, we need a firmware/image with bootloader and partition table merged in it. | |||
| We can use [`cargo-espflash`][cargo-espflash] to generate it: | |||
|
|
|||
| ```shell | |||
| ```console | |||
There was a problem hiding this comment.
Is there any reason to switch code snippets to console from shell. The rest of the book uses shell so it might be worth to keep it consistent.
There was a problem hiding this comment.
OK, back to using bash here.
I may send another PR to use ShellSession.
Closed
src/tooling/simulating/qemu.md
Outdated
| @@ -15,18 +15,20 @@ Once you have built QEMU, you should have the `qemu-system-xtensa` file. | |||
| For running our project in QEMU, we need a firmware/image with bootloader and partition table merged in it. | |||
| We can use [`cargo-espflash`][cargo-espflash] to generate it: | |||
|
|
|||
| ```shell | |||
| ```bash | |||
There was a problem hiding this comment.
Sorry for the misunderstanding, I suggested using shell as before, not bash.
Suggested change
| ```bash | |
| ```shell |
Looks like console and shell are similar, see Shell row: https://github.com/highlightjs/highlight.js/blob/main/SUPPORTED_LANGUAGES.md
Co-authored-by: Sergio Gasquez Arcos <[email protected]>
SergioGasquez
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.