Do not count UDP messages that were not sent #1380
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version of iperf3 (or development branch, such as
master
or3.1-STABLE
) to which this pull request applies:master
Issues fixed (if any):
iperf3 increases packets per seconds for UDP tests after some time #1367
Brief description of code changes (suitable for use as a commit message):
When sending a UDP packet fails, do not increase the packet count. That should improve the statistics, as the next packet will be sent with the same number - practically retry of sending the failed packet instead of sending a new packet. Therefore, the client will not count the "retry" as new packet, and more important, the server will not consider the packet that was not sent as a lots packet.
In addition, added debug message in case of
NET_SOFTERROR
when sending UDP messages, to help debugging.