Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fixing issue with leading prefix in path. #330

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

safaci2000
Copy link
Contributor

@safaci2000 safaci2000 commented Jan 7, 2025

Fixes #323

Documentation updates for gdg config options

@safaci2000 safaci2000 force-pushed the feature/cloudLeadingSlash branch from 58425c6 to dd0b60f Compare January 7, 2025 17:55
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 82.55814% with 15 lines in your changes missing coverage. Please review.

Project coverage is 47.55%. Comparing base (86ad61b) to head (09653ec).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/storage/storage_cloud.go 73.33% 4 Missing ⚠️
internal/service/folders.go 40.00% 3 Missing ⚠️
internal/service/common.go 88.88% 1 Missing and 1 partial ⚠️
internal/service/connection_permissions.go 0.00% 1 Missing ⚠️
internal/service/dashboard_permissions.go 50.00% 1 Missing ⚠️
internal/service/dashboards.go 93.33% 1 Missing ⚠️
internal/service/organizations.go 0.00% 1 Missing ⚠️
internal/service/user.go 0.00% 1 Missing ⚠️
pkg/test_tooling/containers.go 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #330      +/-   ##
==========================================
+ Coverage   47.09%   47.55%   +0.45%     
==========================================
  Files          84       84              
  Lines        6603     6635      +32     
==========================================
+ Hits         3110     3155      +45     
+ Misses       3124     3113      -11     
+ Partials      369      367       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@safaci2000 safaci2000 force-pushed the feature/cloudLeadingSlash branch from dd0b60f to 09653ec Compare January 7, 2025 20:14
@safaci2000 safaci2000 requested a review from arlake228 January 7, 2025 20:25
@safaci2000 safaci2000 changed the title [BUG] Fixing issue with leading prefix in path. [BUG] Fixing issue with leading prefix in path and documentation updates for gdg config options Jan 8, 2025
@safaci2000 safaci2000 changed the title [BUG] Fixing issue with leading prefix in path and documentation updates for gdg config options [BUG] Fixing issue with leading prefix in path. Jan 8, 2025
@safaci2000 safaci2000 merged commit b3a61c4 into main Jan 8, 2025
7 checks passed
@safaci2000 safaci2000 deleted the feature/cloudLeadingSlash branch January 9, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Using a leading / in output_path breaks dashboard restore
2 participants