Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixes invalid cross-device link for dashboard when /tmp lies on another partition #195

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

madhur
Copy link
Contributor

@madhur madhur commented Sep 17, 2023

The default implementation of fileblob uses /tmp partition to create files.

If the /tmp lies on another partition, this results in error which is seen in Issue #194

The fix passes the additional options while creating the bucket which instructs not to use /tmp partition but instead use the same folder.

// If true, don't use os.TempDir for temporary files, but instead place them
	// next to the actual files. This may result in "stranded" temporary files
	// (e.g., if the application is killed before the file cleanup runs).
	//
	// If your bucket directory is on a different mount than os.TempDir, you will
	// need to set this to true, as os.Rename will fail across mount points.

@safaci2000
Copy link
Contributor

Interesting use case you ran into. Thanks for fixing this.

@safaci2000 safaci2000 merged commit f86387c into esnet:master Sep 22, 2023
@madhur
Copy link
Contributor Author

madhur commented Sep 22, 2023 via email

safaci2000 pushed a commit that referenced this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants