-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE-436: PDFJS 4.x + VTT Content Search API + Mirador 4.0 alpha 2 + ML #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not a lot since we have so far next/prev. But it does work. Tab selection. Passes the tests.
DiegoPino
added
enhancement
New feature or request
Javascript
Favourite language of a PHP developer
Field Formatter
The thing that glues the pieces and adds glitter
UX
Like UI but with an X
Working Group's 💜
Imagined, curated and loved by the Working Group
Search and Discovery
Mess around and find out
labels
Apr 4, 2024
DiegoPino
commented
Apr 4, 2024
|
||
var scale = 1.5; | ||
var viewport = page.getViewport({scale: scale}); | ||
import("https://cdn.jsdelivr.net/npm/[email protected]/build/pdf.min.mjs").then((pdfjsLib) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two here could be settings passed by PHP .... have to think about it
… pure text to the Content Search API @alliomeria (will explain tomorrow)
… too Next step is to make 3 different queries based on what processors we have (so far this just does OCR so X/Y and Time) And add JMESPATH expressions to extract VTTs and Plain Text from annotations associated to a canvas. @alliomeria more soon! (we are close :)
+ Plus a whole veggie garden of code to support VTT
@alliomeria 4.0.0 alpha-2 at least allows an user to pick a subtitle, does not enable one by default though.
…st yet So we can still dispatch an event, but not from our Window Dom, but from the parent/initialized Archipelago DIV (will it work? who knows ... but probably was not working before anyways hahaha)
…ernal items level. So basically a new JMESPATH selector (wish i had better things to do on a weekend)
…ion OR a Canvas as target. None of these work with Mirador sadly (at least so far)
.. but i have not yet implemented the extra "hits" structure for V1 or "Annotations" for V2 that allow the before and after to be used. @alliomeria will explain during our call
A single file_uuid per hit.
DiegoPino
changed the title
ISSUE-436: PDFJS 4.x
ISSUE-436: PDFJS 4.x + VTT Content Search API
Apr 30, 2024
DiegoPino
changed the title
ISSUE-436: PDFJS 4.x + VTT Content Search API
ISSUE-436: PDFJS 4.x + VTT Content Search API + Mirador 4.0 alpha 2
Apr 30, 2024
@alliomeria you will have a great presentation. I'm not sure about OR (me) though!
…s on single images Not ready. Lot's to do still. This is 🌰
But i will have to remove tons of code afterwards (means this commit basically does not work because of a Drupal bug that leads to all Drupal.views stored globally being deleted when two ajax views are present in the same page and one uses the Pager of one... damn)
…extual one Also, for contextual ones, use the "exception" value instead of NULL So we can avoid passing "NULL" and end being not validated because of that. $executable->exposed_data = $filters; was the trick ..
DiegoPino
changed the title
ISSUE-436: PDFJS 4.x + VTT Content Search API + Mirador 4.0 alpha 2
ISSUE-436: PDFJS 4.x + VTT Content Search API + Mirador 4.0 alpha 2 + ML
May 27, 2024
So far so good. But the Actual Search needs adapting for non OCR so we return a proper annotation
@alliomeria need to share the IIIF Manifest that drives this. Very similar to VTT
When multiple canvas, videos,audios, text are all present in the Content Search Results
…ht take that time @alliomeria i think i got it this time. But i can't say for sure. At least nothing breaks and the canvas swapping does work
@alliomeria Merging. Will keep working on the new issue/features in other branches, this one just became too huge.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
Field Formatter
The thing that glues the pieces and adds glitter
Javascript
Favourite language of a PHP developer
Search and Discovery
Mess around and find out
UX
Like UI but with an X
Working Group's 💜
Imagined, curated and loved by the Working Group
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #436