Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-414-1.4.0--leaflet-options --> 1.4.0 #416

Merged

Conversation

patdunlavey
Copy link
Collaborator

What

1.4.0 version of this PR

  • Added leaflet map option for 'Disable …mouse wheel zoom'.
  • Reduced the minimum map height to 62px, which guarantees that the +/- buttons will display.

To Test:

  • Edit "Map Display for Digital Objects SQL view (/admin/structure/views/view/map_display_for_digital_objects_sql) view
  • Click on the field settings for "Content: 🍓 Strawberry (Descriptive Metadata source)" to bring up the configuration form for that field.
  • Test the view with different values for "Maximum height". Any height equal to or larger than 62 pixels should be able to be saved, and should be reflected in height of the map that is displayed when the view is rendered for an object.
  • Set the "Disable mouse wheel zoom" checkbox to unchecked (it's the default) and save the view. When viewing the map, scrolling the mouse wheel should cause the map to zoom in and out.
  • Check the "Disable mouse wheel zoom" checkbox and save the view. Now, using the mouse wheel to scroll the page that the map is rendered on should not cause the map to zoom when the cursor enters the map area.

…mouse wheel zoom'. Also reduced the minimum map height to 62px, which guarantees that the +/- buttons will display.
…or when the 'display.default.display_options.fields.field_descriptive_metadata.settings.disable_mouse_zoom' configuration is not set. Add field.formatter.settings.strawberry_map_formatter.mapping.disable_mouse_zoom to format_strawberryfield.schema.yml.
@patdunlavey
Copy link
Collaborator Author

Updated after review on the 1.3.0 companion PR.

Copy link
Member

@DiegoPino DiegoPino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks @patdunlavey

@DiegoPino DiegoPino assigned DiegoPino and patdunlavey and unassigned DiegoPino Feb 15, 2024
@DiegoPino DiegoPino added this to the 1.4.0 milestone Feb 15, 2024
@DiegoPino DiegoPino added Javascript Favourite language of a PHP developer Field Formatter The thing that glues the pieces and adds glitter UX Like UI but with an X labels Feb 15, 2024
@DiegoPino DiegoPino merged commit cf23b58 into esmero:1.4.0 Feb 15, 2024
@patdunlavey
Copy link
Collaborator Author

Woohoo!

@patdunlavey patdunlavey deleted the Issue-414-1.4.0--leaflet-options branch February 15, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Field Formatter The thing that glues the pieces and adds glitter Javascript Favourite language of a PHP developer UX Like UI but with an X
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants