ISSUE-207-1.3 --- Moved twig context alter hook inside the render con… #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…text to avoid potential cache 'leakage' errors.
DiegoPino
requested changes
Dec 15, 2023
| // In case someone decided to wipe the original context? | ||
| // We bring it back! | ||
| $context = $context + $original_context; | ||
| $cacheabledata = []; |
There was a problem hiding this comment.
@patdunlavey can you keep please $cacheabledata = []; in line 281?
There was a problem hiding this comment.
I'm afraid I don't understand. Restoring it to a position before $this->renderer->executeInRenderContext will simply result in it being overwritten, and putting it after will clobber the result of $this->renderer->executeInRenderContext, and putting it inside the inline function does nothing that I can see.
There was a problem hiding this comment.
Nevermind. I've gone ahead and updated the issue branch with the change as requested (and as I understand it).
DiegoPino
approved these changes
Dec 15, 2023
DiegoPino
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #392 for 1.2.0 PR