ISSUE-348: Adds a pseudo Node "Upcaster" for Routed Views in the presence of "Active Display Settings" tab #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tries to get around the exception of a View using %node as a parameter but not upcasting it to NodeInterface. It, of course, does this without too much overhead, which means it does not processes the View Entity Itself and simply assumes a view_id + node argument are reasons enough to enrich the Route. It is important to node that really only place where this can happen is when a View's path is node/%node given that (fixed in code) that is where our Route (Active Display settings) will call this class. Basically when Node level Tabs (actions) and View level Actions depend on each other
DiegoPino
added
bug
aksm
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Tested with a View that touches here and works as expected without any issues. Thanks, @DiegoPino!
Co-authored-by: Albert Min <[email protected]>
|
Thanks, addressed the wording too. Thanks for catching that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #348
This tries to get around the exception that happens when a View uses %node as a parameter, but does not upcast it the value to NodeInterface. It (of course) does this without too much overhead, which means it does not processes the View Entity Itself and we simply assume a
view_id+nodeargument are reasons enough to enrich the Route. It is important to node that really only place where this can happen (so pretty edge case) is when a View's path is node/%node given that (fixed in code) that is where our Route (Active Display settings) will call this class. Basically when Node level Tabs (actions) and View level Actions depend on each other/live side by side.