ISSUE-271: Deal with Empty Queries on Advanced and Facet Summary for Queries #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And remove empties from Facet Queries.
So we discard empties... but we keep the untrimmed if the trim is not emtpy...
DiegoPino
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #271. Includes some fixes for Advanced searches (Direct Parser) where we know (now) that Drupal's Parse Mode Parser DOES NOT know how to deal with an empty and we end with just the
#conjunctionwhich means a wrong Parsed Solr query. This filters out anything that after trimming == '' but preserves spaces on the query term if that is not the case.There might be other "Edge" cases but we can start with what we know right?