ISSUE-128: Basic pass custom Mirador 3.3.0 with Image tools #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I could not make the awesome text-overlay the Johannes wrote play with image tools that community asked for. When both are enabled image tools are not drawn. I have no idea what is happening and that will imply extra work. Some funkyness with opening new manifests when pressing on the blue signs are also happening, might be some material-layour issue, a css that is missing, a selector or even the URL parser. JS -react- are a mistery for me
DiegoPino
added
enhancement
|
@patdunlavey seems like the problem (finally) is related to React version in the newer Mirador. The solution is to re-build all of this on a previous release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #128
I could not make the awesome text-overlay that Johannes wrote play with image-tools that our community asked for. When both are enabled image tools are not drawn. I have no idea what is happening and that will imply extra work. Some funkyness with opening new manifests when pressing on the blue signs are also happening, might be some material-layour issue, a css that is missing, a selector or even the URL parser. JS -react- is a mystery for me.
Anyhow. This works. Will add a second JS with just text-select to cover that need and since we are loading this selectively I will enable that option too
Will also commit at the same time UV viewer here. That covers more needs. Will try to dig deeper in what is wrong with the super simple custom Webpack JS I built but I have the feeling it is an issue with one of the dependencies (2pm might have gotten something a BIT newer)