ISSUE-197: Clears BookReader/OSD and Annotorious cross dependencies #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved all extensions needed for BookReader to the plugin JS. That way OSD does not need to initialize the Web Worker. In the future i can revisit the Annotation loading so pages of a Book that are annotated show (or can be annotated) in the Zoom @giancarlobi build a while ago
DiegoPino
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #197:
Moved all extensions needed for BookReader to the plugin JS. That way OSD does not need to initialize the Web Worker. In the future i can revisit the Annotation loading so pages of a Book that are annotated show (or can be annotated) in the Zoom @giancarlobi build a while ago.
Small fix for the release. The actual ISSUE needs to stay open until I re-recheck @aksm pull on the same matter.