ISSUE-203:OpenCV is the new Black #204
Conversation
This makes now main load of pages slimmer, adds new openCV worker + utils + UX for annotations and even some cool SVG icons
DiegoPino
added
enhancement
|
@DiegoPino Just got this running on a local instance. Will begin reviewing the code now. |
There was a problem hiding this comment.
Didn't review too closely since I don't want to delay merging, but testing functionality didn't reveal any major errors. @DiegoPino probably you've already noticed this, but the FS error goes away when I add a breakpoint and resume so looks like some kind of race condition? Will continue to debug to see if I can figure anything out.
| - core/drupal | ||
| - core/drupalSettings | ||
| - format_strawberryfield/iiif_openseadragon | ||
| - format_strawberryfield/annotoriousopenseadragon |
There was a problem hiding this comment.
| - format_strawberryfield/annotoriousopenseadragon | |
| - format_strawberryfield/annotoriousopenseadragon | |
| - format_strawberryfield/opencv |
Adding opencv as a dependency seems to get rid of the FS error in my testing.
There was a problem hiding this comment.
@aksm can you open tomorrow another issue about adding opencv as a dependency + maybe some extra small fixes? (e.g now with the tool bar the whole OSD height overlays with the other field formatters). Reason I do not want to go blindly with this is because OpenCV is 8 Mbytes in size, so making it a dependency will force it to load synchronously instead via the Web Worker (background)
What?
See #203
Leaving this here and getting a coffee