Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 140b #145

Merged
merged 6 commits into from
Nov 24, 2021
Merged

Issue 140b #145

merged 6 commits into from
Nov 24, 2021

Conversation

alliomeria
Copy link
Contributor

Hello @DiegoPino & @aksm --this pull contains some updates to the twig templates (just the .twig.html files, not the encoded .json versions), and an updated default descriptive metadata webform. The webform needs additional help text in a few spots (noted in that commit). Hope all of this is looking to be in pretty good shape. Please let me know if any changes are needed. Thank you very much!

Updated to include mesh, europeana, and date_embargo_lift
Updated November 2021: trim output of data.description, add Rights Statement mapping, and show trimmed output for data.rights (local rights statement)
Updated November 2021: addition of Embargo option, |markdown_2_html for data.description and data.rights, change <footer> for <div>
Still needs: 
- help text for sequence_id, elements that make use markdown in default twig templates, vtt for audio/video, and textures for 3 models
@alliomeria alliomeria added Deployment Strategies What every vendor would love to Copy and pasta Twig {% burp %} labels Nov 24, 2021
Copy link
Member

@DiegoPino DiegoPino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx so much. Looks great

@DiegoPino DiegoPino merged commit 9f6678d into esmero:ISSUE-140b Nov 24, 2021
@DiegoPino DiegoPino added this to the 1.0.0-RC3 milestone Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deployment Strategies What every vendor would love to Copy and pasta Twig {% burp %}
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants