Breaking: Bump to [email protected], typescript@~3.2.1

[nevir]

From what I can tell, the main change in typescript-estree is added support for BigIntLiterals. Added some snapshots for 'em, as well.

---

Should this be a major bump due to the typescript upgrade? Or only minor?

[jsf-clabot]

All committers have signed the CLA.

[armano2]

can you add new nodes to visitor-keys

[kaicataldo]

Given the discussion in this PR, the team seems to be in general consensus that the "supported TS version" change is a breaking change.

[kaicataldo]

Do you mind also updating the readme with the supported TS version range?

[nevir]

can you add new nodes to visitor-keys

Hmm, I'm not quite sure which nodes would need to be added to visitor-keys (and by that, you mean ./visitor-keys.js?). Seems like this is only adding a new literal value type (BigIntLiteral ), and that doesn't seem to fit with the structure of that file. I admit, though, I'm not too familiar w/ how eslint juggles the AST.

Do you mind also updating the readme with the supported TS version range?

👍 Done. Also switched the version constraint to a ^, as suggested in #573 (comment)

[armano2]

@nevir you should just add "BigIntLiteral": [] to ./visitor-keys.js

[platinumazure]

Is BigIntLiteral a node type? Or is it a type of the existing Literal node?

[armano2]

@platinumazure its new node type
https://github.com/JamesHenry/typescript-estree/blob/master/src/convert.ts#L2007

[justinanastos]

I just wanted to chime in and say thank you to everyone who's working on this! Great work!

[nevir]

Added the node type

[nevir]

@kaicataldo, is there anything else you'd like me to tweak?

Concern has been addressed

[KaelWD]

7.0.0 just came out

[armano2]

7.0.0 has breaking changes -> ast structure has changed
JamesHenry/typescript-estree@159c325

[armano2]

@KaelWD i did pr with changes for 7.0.0 in #584

[platinumazure]

Hi @nevir, apologies for letting this sit over the holidays.

Is this PR still needed now that #589 has been created?

[JamesHenry]

Thanks a lot for this @nevir and I am sorry for the delay - your commits (with you still as the author) are included directly in #596, so I am closing this in favour of that one.

Thanks again!