Skip to content
This repository has been archived by the owner on Jan 19, 2019. It is now read-only.

Chore: Make ESLint a devDependency/peerDependency (fixes #523) #526

Merged
merged 3 commits into from
Oct 31, 2018
Merged

Chore: Make ESLint a devDependency/peerDependency (fixes #523) #526

merged 3 commits into from
Oct 31, 2018

Conversation

platinumazure
Copy link
Member

No description provided.

ficristo
ficristo reviewed Oct 13, 2018
View reviewed changes
package.json Outdated
"typescript-estree": "2.1.0"
},
"peerDependencies": {
"eslint": "^4.19.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to move to eslint 5?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I had intended to leave it open but I should have used >=. I'll check the ESLint migration guide and, if feasible/not breaking, make that change this weekend. (Fairly sure it can be done without breaking users but just want to check.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ficristo This is fixed. Sorry for the delay.

kaicataldo
kaicataldo reviewed Oct 15, 2018
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there are any changes in this list that affect the parser, but definitely would be best to check!

@platinumazure
Copy link
Member Author

I've pushed a change to allow [email protected] peer dependencies. I'll leave this another day or so and then merge if no one raises any issues.

Thanks for your patience everyone-- work has been crazy.

@JamesHenry
Copy link
Member

@platinumazure I have fixed a conflict after merging in the visitor keys PR, if you are still happy with it please feel free to merge

@platinumazure
Copy link
Member Author

Thank you @JamesHenry, I'll merge as all checks have passed!

@platinumazure platinumazure merged commit 075d243 into master Oct 31, 2018
@platinumazure platinumazure deleted the eslint-peer-dependency branch October 31, 2018 01:02
@JamesHenry
Copy link
Member

@platinumazure Thanks! I'll cut a release now

This was referenced Oct 31, 2018
Merged
Closed
platinumazure added a commit that referenced this pull request Oct 31, 2018
@platinumazure
Revert "Chore: Make ESLint a devDependency/peerDependency (fixes #523) (
473a0dd 
#526)"

This reverts commit 075d243.
@platinumazure platinumazure mentioned this pull request Oct 31, 2018
Merged
platinumazure added a commit that referenced this pull request Oct 31, 2018
@platinumazure
Revert "Chore: Make ESLint a devDependency/peerDependency (fixes #523)…
1683169 
…" (#537)

* Revert "20.1.0"

This reverts commit de1f514.

* Revert "Build: changelog update for 20.1.0"

This reverts commit edbe70e.

* Revert "Chore: Make ESLint a devDependency/peerDependency (fixes #523) (#526)"

This reverts commit 075d243.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ficristo ficristo ficristo left review comments

@kaicataldo kaicataldo kaicataldo approved these changes

@JamesHenry JamesHenry JamesHenry approved these changes

Assignees
No one assigned
Labels
triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@platinumazure @JamesHenry @kaicataldo @ficristo