Skip to content
This repository has been archived by the owner on Jan 19, 2019. It is now read-only.

Fix: Added missing yml lf gitattribute #104

Merged
merged 1 commit into from
Oct 15, 2016
Merged

Fix: Added missing yml lf gitattribute #104

merged 1 commit into from
Oct 15, 2016

Conversation

JamesHenry
Copy link
Member

@JamesHenry JamesHenry commented Oct 13, 2016

Since the gitattribute file was added in #97, my mac has automatically had unstaged changes relating to yml files.

I have never used gitattributes before, but adding a definition for yml seems to do the trick...

@eslintbot
Copy link

Thanks for the pull request, @JamesHenry! I took a look to make sure it's ready for merging and found some changes are needed:

  • Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@dannyfritz
Copy link
Contributor

Hrmm. I wonder if text=auto was causing your mac to use \r\n or something really weird like that. My impression is it will choose the system default which should b fine.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nzakas nzakas merged commit 45b9874 into master Oct 15, 2016
@JamesHenry JamesHenry deleted the gitattributes-yml branch October 29, 2016 22:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants