Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Language#normalizeLanguageOptions() #131

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Nov 5, 2024

Prerequisites checklist

What is the purpose of this pull request?

Add normalizeLanguageOptions to the Language type.

What changes did you make? (Give an overview)

Added an optional normalizeLanguaeOptions() method to the Language type.

Related Issues

refs eslint/eslint#19037

Is there anything you'd like reviewers to focus on?

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Not sure if we should wait for the implementation of this feature before merging this.

@nzakas
Copy link
Member Author

nzakas commented Nov 6, 2024

Probably a good idea to avoid confusion. I wish GitHub had a "schedule" feature.

Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Leaving open until eslint/eslint#19104 is ready to merge.

@mdjermanovic mdjermanovic merged commit 3591a78 into main Nov 14, 2024
17 checks passed
@mdjermanovic mdjermanovic deleted the normalize-lang-options branch November 14, 2024 16:36
@github-actions github-actions bot mentioned this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

3 participants