docs: Use prerendered sponsors for README #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-github-bot
bot
added
the
documentation
tools/update-readme.js
Outdated
| newReadme = newReadme.replace( | ||
| /<!--techsponsorsstart-->[\w\W]*?<!--techsponsorsend-->/u, | ||
| formatTechSponsors(techSponsors), | ||
| `<!--sponsorsstart-->\n\n${allSponsors}\n<!--sponsorsend-->`, |
There was a problem hiding this comment.
why do we have two new line in this repo alone? whilst we dont have it in other eslint/js and eslint/eslint repo?
There was a problem hiding this comment.
Without the second one, in this repo Prettier would be reporting a formatting error there.
There was a problem hiding this comment.
I also added another new line in the fetched content, for the same reason (eslint/eslint.org#648).
1 task
amareshsm
reviewed
Oct 6, 2024
tools/update-readme.js
Outdated
| </p> | ||
| <!--techsponsorsend-->`; | ||
| async function fetchSponsorsMarkdown() { | ||
| return got(SPONSORS_URL).text(); | ||
| } | ||
|
|
||
| //----------------------------------------------------------------------------- | ||
| // Main | ||
| //----------------------------------------------------------------------------- | ||
|
|
||
| (async () => { |
There was a problem hiding this comment.
Suggested change
| (async () => { |
remove IIFE fn
There was a problem hiding this comment.
Removed in 0911a8f now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Simplifies script that adds sponsors to READMEs.
What changes did you make? (Give an overview)
Updated
tools/update-readme.jsto use prerendered sponsors markdown from the eslint.org repo.Related Issues
eslint/eslint.org#619
Is there anything you'd like reviewers to focus on?