Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Updating CLA link #93

Merged
merged 2 commits into from
Apr 14, 2018
Merged

Docs: Updating CLA link #93

merged 2 commits into from
Apr 14, 2018

Conversation

pnevares
Copy link
Contributor

Howdy! 👋

Was looking at contributing to the project but the CLA link in CONTRIBUTING.md wasn't loading. This update looks like the right one.

Thank you!

@pnevares pnevares changed the title Updating link to CLA Docs: Updating CLA link Apr 13, 2018
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the CLA tool operates per repository, with the last 2 segments of the URL being the organization/owner and the repository. So I think it might be correct to end with /eslint/eslint-plugin-markdown.

Not 100% sure though. 😄

@pnevares
Copy link
Contributor Author

I can definitely update it to that path if I can get confirmation it's the correct one. Thanks for the note!

@platinumazure
Copy link
Member

platinumazure commented Apr 14, 2018

@kborchers Sorry to bother you, but I just want to confirm that the CLA URL paths should generally look like https://cla.js.foundation/<org>/<repo>, right? So the CLA for this repo should be eslint/eslint-plugin-markdown? Thanks!

@kborchers
Copy link

@platinumazure that is correct though CLA signatures are valid on an org basis so technically if they went to /eslint/eslint and signed it would work on this repo going forward as well.

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@platinumazure platinumazure merged commit 5582fce into eslint:master Apr 14, 2018
@pnevares
Copy link
Contributor Author

Thank you for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants