Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Explicitly specify package.json files #67

Merged
merged 1 commit into from
Apr 30, 2017
Merged

Build: Explicitly specify package.json files #67

merged 1 commit into from
Apr 30, 2017

Conversation

btmills
Copy link
Member

@btmills btmills commented Apr 30, 2017

eslint-release expects pkg.files to be an array of relative paths without any globs.

lib/.eslintrc.yml shouldn't be included in the bundle, so it's necessary to specify individual paths instead of just lib.

`eslint-release` expects `pkg.files` to be an array of relative paths
without any globs. `lib/.eslintrc.yml` shouldn't be included in the
bundle, so it's necessary to specify individual paths instead of just
`lib`.
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this seems like a bug in eslint-release that we should fix.

@btmills
Copy link
Member Author

btmills commented Apr 30, 2017

Agreed, working on an issue for that now.

@btmills btmills merged commit c5e9d67 into master Apr 30, 2017
@btmills btmills deleted the files branch April 30, 2017 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants