Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release 6.0.0 πŸš€ #261

Conversation

github-actions[bot]
Copy link
Contributor

πŸ€– I have created a release beep boop

6.0.0 (2024-07-16)

⚠ BREAKING CHANGES

  • map known code block languages to respective file extensions (#246)
  • drop eslint < 8 & Node.js < 18 (#238)
  • Switch to flat config (#232)
  • drop node v8 and v10 (#203)

Features

Bug Fixes


This PR was generated with Release Please. See documentation.

@mdjermanovic
Copy link
Member

Looks like it included all commits with releasable tags from the main branch. Seems like we need to specify bootstrap-sha when switching from release-please v3 to v4?

@mdjermanovic
Copy link
Member

Or perhaps this is a problem with tags.

❯ looking for tagName: eslint-plugin-markdown-v5.1.0

https://github.com/googleapis/release-please/blob/main/docs/manifest-releaser.md#subsequent-versions

The current setup will be creating and looking for tags in the format eslint-plugin-markdown-v<release-version> but we were using tags in the format v<release-version>, so the question is should we continue using the old format (and update tags settings in the release please config) or switch to the new format (in which case we'd probably need to specify bootstrap-sha)?

version: "5.1.0" // x-release-please-version
version: "6.0.0" // x-release-please-version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works πŸ‘

@nzakas
Copy link
Member

nzakas commented Jul 17, 2024

Yeah, I figured something would break and we'd need to adjust. Just wanted to see what broke first. :) I'll take a look.

@mdjermanovic
Copy link
Member

Okay, seems like 618a9f5 fixed this.

https://github.com/eslint/eslint-plugin-markdown/actions/runs/9977023767/job/27570640115

...
❯ Found release for path ., v5.1.0
❯ release for path: ., version: 5.1.0, sha: f75e14d9729a6107649d19cf540cc5385588fc4d
...
βœ” No user facing commits found since f75e14d9729a6107649d19cf540cc5385588fc4d - skipping

Just looks like it doesn't close existing release PRs, so I'll close this manually.

@nzakas nzakas deleted the release-please--branches--main--components--eslint-plugin-markdown branch July 17, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment