Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: npm prepare script on Windows (refs #166) #168

Merged
merged 4 commits into from
Dec 20, 2020
Merged

Fix: npm prepare script on Windows (refs #166) #168

merged 4 commits into from
Dec 20, 2020

Commits on Dec 16, 2020

  1. Chore: Test on Windows and macOS

    @btmills
    btmills committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    669bdc9 View commit details
    Browse the repository at this point in the history

  2. Fix: npm prepare script on Windows (refs #166) 

    The previous script worked on macOS and Linux, but I neglected to
consider Windows. This wouldn't affect users thankfully, only
developers, so the blast radius would have been small had it not been
caught. Now that we're testing on Windows, future bugs like this should
be caught. I'm out of ideas for doing this entirely inside npm scripts,
so I broke down and did it in JS.
    @btmills
    btmills committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    c2dcea2 View commit details
    Browse the repository at this point in the history

  3. Chore: Increase test timeout for Windows and macOS runners 

    They occasionally exhibit extremely slow filesystem performance.
    @btmills
    btmills committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    5ce9540 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2020

  1. Add npm-prepare script JSDoc header

    @btmills
    btmills committed Dec 20, 2020
    Configuration menu
    Copy the full SHA
    b752b5d View commit details
    Browse the repository at this point in the history