Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Indent multiline fixes (fixes #120) #124

Merged
merged 5 commits into from
Oct 22, 2019
Merged

Fix: Indent multiline fixes (fixes #120) #124

merged 5 commits into from
Oct 22, 2019

Commits on Sep 7, 2019

  1. Chore: Add failing test case for indent of multiline fixes

    If the replacement text of an autofix contains newlines, all lines but
    the first in the replacement text will unexpectedly have 0 indentation
    if a code block is indented. I guess not only the _range_ of fixes but
    also the _text_ of fixes need to be adjusted.
    
    If the code block is placed within a blockquote, a `>` character also
    needs to be inserted.
    
    This issue was found while investigating
    lydell/eslint-plugin-simple-import-sort#22.  That plugin several lines
    of imports in one go. This means that most of the imports will have too
    little indentation after autofix if the code block is indented (such as
    when placed in a list).
    lydell committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    5502a18 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2019

  1. Configuration menu
    Copy the full SHA
    f308f99 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0e14506 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    74c1473 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2019

  1. Configuration menu
    Copy the full SHA
    80edd59 View commit details
    Browse the repository at this point in the history