Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade: acorn to 7.1.1 #434

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Upgrade: acorn to 7.1.1 #434

merged 1 commit into from
Mar 9, 2020

Conversation

jmz527
Copy link
Contributor

@jmz527 jmz527 commented Mar 6, 2020 •
edited
Loading

fixes "Regular Expression Denial of Service" vulnerability (fixes #435)

@jsf-clabot
Copy link

jsf-clabot commented Mar 6, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kaicataldo
Copy link
Member

@jmz527 Can you please sign the CLA so that we can review this? Thanks!

@hugoluchessi
Copy link

Please @jmz527 edit you commit message to the guideline.
I've just created the issue (#435)

@alewitt2
Copy link

alewitt2 commented Mar 9, 2020 •
edited
Loading

Upgrade the acorn npm package from 7.1.0 => 7.1.1 to fix "Regular Expression Denial of Service" vulnerability.

maybe something like
Upgrade: acorn to 7.1.1, fixes "Regular Expression Denial of Service" vulnerability (fixes #435)

@jmz527
Copy link
Contributor Author

jmz527 commented Mar 9, 2020

Commit message edited.

@alewitt2
Copy link

alewitt2 commented Mar 9, 2020 •
edited
Loading

see here to update commit and PR title
image

@jmz527 jmz527 changed the title Update package.json to fix security vulnerability Upgrade: acorn to 7.1.1 Mar 9, 2020
@jmz527
Copy link
Contributor Author

jmz527 commented Mar 9, 2020

@alewitt2 Ah, sorry. Caught me multi-tasking. How's that?

@alewitt2
Copy link

alewitt2 commented Mar 9, 2020 •
edited
Loading

@jmz527 PR looks good now. still need to update the actual commit message to something like Upgrade: acorn to 7.1.1, fixes "Regular Expression Denial of Service" vulnerability (fixes #435)

git commit --amend
git push --force

@alewitt2
Copy link

alewitt2 commented Mar 9, 2020 •
edited
Loading

@jmz527 looks like that committ is too long.. try this instead Upgrade: acorn 7.1.1, Regex DOS vuln (fixes #435)

hugoluchessi
hugoluchessi approved these changes Mar 9, 2020
View reviewed changes
Copy link

@hugoluchessi hugoluchessi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hugoluchessi hugoluchessi mentioned this pull request Mar 9, 2020
Closed
@alewitt2
Copy link

alewitt2 commented Mar 9, 2020

@kaicataldo should be good to go

@nzakas nzakas merged commit d6d7480 into eslint:master Mar 9, 2020
@einSelbst
Copy link

related to eslint/eslint#13012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alewitt2 alewitt2 alewitt2 approved these changes

@hugoluchessi hugoluchessi hugoluchessi approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

@gyandeeps gyandeeps gyandeeps approved these changes

Assignees
No one assigned
Labels
triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Acorn dependency has a vulnerability on version v7.1.0
8 participants
@jmz527 @jsf-clabot @kaicataldo @hugoluchessi @alewitt2 @einSelbst @gyandeeps @nzakas