Update: improve error messaging when validating ecmaVersion #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaicataldo
changed the title
kaicataldo
force-pushed
the
ecmaversion-number-error
branch
from
d749279
to
40b62ea
Compare
|
Whoops, fixed the commit message 😅 |
ljharb
approved these changes
Aug 15, 2019
|
(fwiw using |
|
Cool, useful to know 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by eslint/eslint#12101. This PR enhances the error messaging when validating
ecmaVersionto distinguish between when the the value provided is the incorrect data type versus when it's not a valid numeric value.I labeled this an enhancement since it's not technically a bug fix, but please let me know if you disagree!