feat: add the `eslint-scope` package #615

snitin315 · 2024-07-21T11:57:58Z

Refers #609

nzakas

The moved files look good. We also need to update release-please-config.json and .release-please-manifest.json to ensure that release-please knows about this package.

nzakas · 2024-07-22T15:22:21Z

eslint.config.js

        languageOptions: {
            globals: {
                ...globals.mocha
            }
+        },
+        plugins: {


Did you intend to add more to this config?

Yeah, this is to match the eslint-scope ESLint config.

I merged both the configs, but, I think we can have different config for packages/espree/tests/lib/** & packages/eslint-scope/tests/lib/** too.

I think we can have different config for packages/espree/tests/lib/** & packages/eslint-scope/tests/lib/**

Sounds good to me to have different configs, because eslint-scope tests use chai while espree tests don't (I'm not sure why chai was listed in espree dev deps).

Updated, also removed chai from espree's dev dep.

nzakas

Looks like we also need to add eslint-scope to the issue templates.

snitin315 · 2024-07-26T07:49:28Z

Updated 👍🏻

mdjermanovic · 2024-07-27T16:16:58Z

Looks like npm-license expects dependencies to be installed in node_modules of the start path. But in a workspaces monorepo, dependencies are installed in top-level node_modules.

When I add console.log(Object.keys(deps)); here, it logs only:

[ '[email protected]' ]

In the old eslint-scope repo, it logs:

[ '[email protected]', '[email protected]', '[email protected]' ]

So it seems that the license check effectively wouldn't work? I'm not sure how this could be fixed and whether we need a license check for the eslint-scope package. We have a license check in eslint/eslint, and eslint-scope seems to be the only other package with this check.

nzakas · 2024-07-29T14:29:29Z

In a monorepo, all dependencies end up in the top-level node_modules, so if we do the license check from the root of the repo, I think it should work.

snitin315 · 2024-08-04T06:06:32Z

Providing the top-level path here also didn't work, it was then outputting [ '[email protected]' ] only.

For now, I have passed additional metadata (See 6405974) to keep the behavior the same as eslint-scope repo, I think we can follow up on this and see how it can be improved for monorepo.

packages/eslint-scope/licensesMetaData.json

packages/eslint-scope/Makefile.js

aladdin-add · 2024-08-07T05:32:40Z

packages/eslint-scope/README.md

@@ -0,0 +1,110 @@
+[![npm version](https://img.shields.io/npm/v/eslint-scope.svg)](https://www.npmjs.com/package/eslint-scope)
+[![Downloads](https://img.shields.io/npm/dm/eslint-scope.svg)](https://www.npmjs.com/package/eslint-scope)
+[![Build Status](https://github.com/eslint/eslint-scope/workflows/CI/badge.svg)](https://github.com/eslint/eslint-scope/actions)


need to update the link after the repo being renamed.

Suggested change

[![Build Status](https://github.com/eslint/eslint-scope/workflows/CI/badge.svg)](https://github.com/eslint/eslint-scope/actions)

[![Build Status](https://github.com/eslint/eslint-scope/workflows/CI/badge.svg)](https://github.com/eslint/js/actions)

Let's update it only after the repo is renamed,

aladdin-add · 2024-08-07T05:36:03Z

packages/eslint-scope/package.json

+{
+  "name": "eslint-scope",
+  "description": "ECMAScript scope analyzer for ESLint",
+  "homepage": "http://github.com/eslint/eslint-scope",


Suggested change

"homepage": "http://github.com/eslint/eslint-scope",

"homepage": "https://github.com/eslint/js#readme",

aladdin-add · 2024-08-07T05:36:22Z

packages/eslint-scope/package.json

+  "engines": {
+    "node": "^18.18.0 || ^20.9.0 || >=21.1.0"
+  },
+  "repository": "eslint/eslint-scope",


Suggested change

"repository": "eslint/eslint-scope",

"repository": "eslint/js",

aladdin-add · 2024-08-07T05:36:40Z

packages/eslint-scope/package.json

+  "repository": "eslint/eslint-scope",
+  "funding": "https://opencollective.com/eslint",
+  "bugs": {
+    "url": "https://github.com/eslint/eslint-scope/issues"


Suggested change

"url": "https://github.com/eslint/eslint-scope/issues"

"url": "https://github.com/eslint/js/issues"

packages/eslint-scope/package.json

nzakas · 2024-08-13T18:00:04Z

@snitin315 are you still working on this?

snitin315 · 2024-08-15T05:38:48Z

@nzakas Yes, somehow I missed the last review notification. I've updated the PR, PTAL.

@aladdin-add Let's change the eslint/eslint-scope to eslint/js in a follow-up PR for all packages, once the repository has been renamed.

aladdin-add

LGTM, pending @nzakas re-review. thanks!

nzakas · 2024-08-15T15:05:02Z

All right, moving this forward. I will rename the repo now.

snitin315 added 2 commits July 21, 2024 15:15

feat: add the eslint-scope package

a87ac81

chor: fix lint & test scripts

d880c37

eslint-github-bot bot added the feature label Jul 21, 2024

nzakas requested changes Jul 22, 2024

View reviewed changes

chore: update release-please configs

0ad2f6f

nzakas reviewed Jul 23, 2024

View reviewed changes

chore: update issue templates & README

d929bc5

snitin315 added 2 commits August 4, 2024 11:20

chore: add license meta data

6405974

chore: refactor eslint config & remove chai from espree dev dep

e9a7fa7

nzakas reviewed Aug 5, 2024

View reviewed changes

packages/eslint-scope/licensesMetaData.json Outdated Show resolved Hide resolved

aladdin-add self-requested a review August 6, 2024 09:33

chore: rename file to licenses-meta-data.json

a839417

aladdin-add previously approved these changes Aug 7, 2024

View reviewed changes

aladdin-add reviewed Aug 7, 2024

View reviewed changes

packages/eslint-scope/package.json Outdated Show resolved Hide resolved

chore: apply suggestions

c756da0

snitin315 dismissed aladdin-add’s stale review via c756da0 August 15, 2024 05:36

aladdin-add approved these changes Aug 15, 2024

View reviewed changes

aladdin-add requested review from nzakas and mdjermanovic August 15, 2024 05:44

nzakas approved these changes Aug 15, 2024

View reviewed changes

nzakas merged commit 2ecfb8b into main Aug 15, 2024
11 checks passed

nzakas deleted the feat/eslint-scope-package branch August 15, 2024 15:05

github-actions bot mentioned this pull request Aug 15, 2024

chore: release main #618

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add the `eslint-scope` package #615

feat: add the `eslint-scope` package #615

snitin315 commented Jul 21, 2024

nzakas left a comment

nzakas Jul 22, 2024

snitin315 Jul 23, 2024 •

edited

Loading

mdjermanovic Jul 26, 2024

snitin315 Aug 4, 2024

nzakas left a comment

snitin315 commented Jul 26, 2024

mdjermanovic commented Jul 27, 2024

nzakas commented Jul 29, 2024

snitin315 commented Aug 4, 2024

aladdin-add Aug 7, 2024

snitin315 Aug 15, 2024

aladdin-add Aug 7, 2024

aladdin-add Aug 7, 2024

aladdin-add Aug 7, 2024

nzakas commented Aug 13, 2024

snitin315 commented Aug 15, 2024

aladdin-add left a comment

nzakas commented Aug 15, 2024

	[![Build Status](https://github.com/eslint/eslint-scope/workflows/CI/badge.svg)](https://github.com/eslint/eslint-scope/actions)
	[![Build Status](https://github.com/eslint/eslint-scope/workflows/CI/badge.svg)](https://github.com/eslint/js/actions)

	"homepage": "http://github.com/eslint/eslint-scope",
	"homepage": "https://github.com/eslint/js#readme",

	"repository": "eslint/eslint-scope",
	"repository": "eslint/js",

	"url": "https://github.com/eslint/eslint-scope/issues"
	"url": "https://github.com/eslint/js/issues"

feat: add the eslint-scope package #615

feat: add the eslint-scope package #615

Conversation

snitin315 commented Jul 21, 2024

nzakas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

snitin315 Jul 23, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nzakas left a comment

Choose a reason for hiding this comment

snitin315 commented Jul 26, 2024

mdjermanovic commented Jul 27, 2024

nzakas commented Jul 29, 2024

snitin315 commented Aug 4, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nzakas commented Aug 13, 2024

snitin315 commented Aug 15, 2024

aladdin-add left a comment

Choose a reason for hiding this comment

nzakas commented Aug 15, 2024

feat: add the `eslint-scope` package #615

feat: add the `eslint-scope` package #615

snitin315 Jul 23, 2024 •

edited

Loading